[fix][client] Fix wrong start message id when it's a chunked message id #23713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
added
type/bug
BewareMyPower
requested review from
lhotari,
Technoboy-,
codelipenghui,
RobertIndie and
poorbarcode
RobertIndie
approved these changes
Dec 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23713 +/- ##
============================================
+ Coverage 73.57% 74.41% +0.83%
- Complexity 32624 34575 +1951
============================================
Files 1877 1945 +68
Lines 139502 147466 +7964
Branches 15299 16271 +972
============================================
+ Hits 102638 109731 +7093
- Misses 28908 29266 +358
- Partials 7956 8469 +513
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 19, 2024
…id (apache#23713) (cherry picked from commit 4606385) (cherry picked from commit c93da6e)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 23, 2024
…id (apache#23713) (cherry picked from commit 4606385) (cherry picked from commit c93da6e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When a reader's start message id is a chunked message id, this chunked message will be read even if
startMessageIdInclusive()is not configured.Modifications
Only use
getFirstChunkMessageIdas the start message id whenstartMessageIdInclusive()is configured. Improve thetestSeekChunkMessagesto verify it.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: