[fix][client] Make DeadLetterPolicy & KeySharedPolicy serializable #23718
+66
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23704
Motivation
We use the pulsar client to consume messages from a Pulsar broker in a Storm topology. Recently, we encountered an issue where the
deadLetterPolicy
that we set on thePulsarSpout
seems to be lost when the topology is started. Upon investigation, we found that this is due to thedeadLetterPolicy
attribute inConsumerConfigurationData
being marked as transient. This prevents us from utilising the dead letter queue feature in our topology.Modifications
Made DeadLetterPolicy, KeySharedPolicy and Range classes implement the java.io.Serializable interface and removed the transient keyword from the corresponding fields in the ConsumerConfigurationData class. In addition, two tests were also modified / updated.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: AnuragReddy2000#1