[fix] [broker] Fix config replicationStartAt does not work when set it to earliest #23719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorbarcode
requested review from
lhotari,
Technoboy-,
codelipenghui,
gaoran10 and
shibd
shibd
approved these changes
Dec 12, 2024
|
/pulsarbot rerun-failure-checks |
lhotari
reviewed
Dec 12, 2024
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
Outdated
Show resolved
Hide resolved
…rviceConfiguration.java Co-authored-by: Lari Hotari <[email protected]>
codelipenghui
approved these changes
Dec 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23719 +/- ##
============================================
+ Coverage 73.57% 74.40% +0.82%
- Complexity 32624 34472 +1848
============================================
Files 1877 1945 +68
Lines 139502 147482 +7980
Branches 15299 16278 +979
============================================
+ Hits 102638 109732 +7094
- Misses 28908 29282 +374
- Partials 7956 8468 +512
Flags with carried forward coverage won't be shown. Click here to find out more.
|
poorbarcode
added a commit
that referenced
this pull request
Dec 13, 2024
…t to earliest (#23719) Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit 39f4ccd)
poorbarcode
added a commit
that referenced
this pull request
Dec 13, 2024
…t to earliest (#23719) Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit 39f4ccd)
poorbarcode
added a commit
that referenced
this pull request
Dec 13, 2024
…t to earliest (#23719) Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit 39f4ccd)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 19, 2024
…t to earliest (apache#23719) Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit 39f4ccd) (cherry picked from commit ab69c3d)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 23, 2024
…t to earliest (apache#23719) Co-authored-by: Lari Hotari <[email protected]> (cherry picked from commit 39f4ccd) (cherry picked from commit ab69c3d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The value of the config named
replicationStartAtareearliestorlatest, but both implementation and test usedMessageId.earliest.toString()that value is-1:-1:-1( so the test works as expected).Therefore, setting
replicationStartAttoearliestdoes not work.Modifications
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x