[improve] [test] Add more test for the case that client receives a SendError, which relates to the PR #23038 #23721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndError, which relates to the PR apache#23038
…ndError, which relates to the PR apache#23038
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23721 +/- ##
============================================
+ Coverage 73.57% 74.41% +0.83%
- Complexity 32624 35083 +2459
============================================
Files 1877 1945 +68
Lines 139502 147481 +7979
Branches 15299 16277 +978
============================================
+ Hits 102638 109746 +7108
- Misses 28908 29259 +351
- Partials 7956 8476 +520
Flags with carried forward coverage won't be shown. Click here to find out more. |
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ClientCnxTest.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ClientCnxTest.java
Outdated
Show resolved
Hide resolved
dao-jun
approved these changes
Dec 13, 2024
Technoboy-
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#23038 changed the behavior of the PulsarClient in handling SendErrors.
Modifications
Add more tests for the change
Producer with the same id is already created1, to confirm users will not get the errorProducer with the same id is already createdDocumentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x