[fix][sec] Mitigate CVE-2024-53990 by disabling AsyncHttpClient CookieStore #23725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eStore - Disable CookieStore by setting it to null in all locations
nodece
approved these changes
Dec 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23725 +/- ##
============================================
+ Coverage 73.57% 74.38% +0.81%
- Complexity 32624 34559 +1935
============================================
Files 1877 1945 +68
Lines 139502 147486 +7984
Branches 15299 16277 +978
============================================
+ Hits 102638 109713 +7075
- Misses 28908 29306 +398
- Partials 7956 8467 +511
Flags with carried forward coverage won't be shown. Click here to find out more.
|
3 tasks
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 19, 2024
…eStore (apache#23725) (cherry picked from commit 51e8247) (cherry picked from commit 78274a7)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 23, 2024
…eStore (apache#23725) (cherry picked from commit 51e8247) (cherry picked from commit 78274a7)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Dec 27, 2024
…eStore (apache#23725) (cherry picked from commit 51e8247) Signed-off-by: Zixuan Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See CVE-2024-53990. There aren't backend services in Pulsar that would use cookies, however since it's a high severity vulnerability, there's a need to mitigate it. Eventually we will need to upgrade to AsyncHttpClient 3.0.1 to get rid of the vulnerable dependency AsyncHttpClient 2.12.x.
Modifications
Additional context
Documentation
docdoc-requireddoc-not-neededdoc-complete