[improve][broker] Improve the extensibility of the TopicBundleAssignmentStrategy interface class (#23773) #23774
+185
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[improve][broker] Improve the extensibility of the TopicBundleAssignmentStrategy interface class (#23773)
Fixes #23773
PIP: #19806
Motivation
For details, see the description of issue #23773
Modifications
The implementation of the
NamespaceBundleFactory#getLongHashCode
method is moved to the implementation class of the interfaceTopicBundleAssignmentStrategy
. Therefore, a new methodlong getHashCode(String name)
is added to theTopicBundleAssignmentStrategy
interface class. The implementation of the hash algorithm is no longer fixed in theNamespaceBundleFactory#getLongHashCode
method. Instead, thegetHashCode
method implemented by different algorithms is invoked.Verifying this change
This change is already covered by existing tests, such as TopicBundleAssignmentStrategyTest#testStrategyFactory, and added tests and can be verified as follows:
TopicBundleAssignmentStrategyTest
RoundRobinBundleAssigner
is customized and theTopicBundleAssignmentStrategy
interface is implemented. Only the interfaces inTopicBundleAssignmentStrategy
need to be implemented. It's not needed to modify the interface implementation of other classes. The open and closed principles are met.Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: