Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][improve][ml] Make offloader threshold config dynamic #23775

Closed

Conversation

dao-jun
Copy link
Member

@dao-jun dao-jun commented Dec 24, 2024

Motivation

Make offloader threshold configs dynamic

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@dao-jun dao-jun self-assigned this Dec 24, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 24, 2024
@dao-jun dao-jun added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages and removed doc-not-needed Your PR changes do not impact docs labels Dec 24, 2024
@dao-jun dao-jun added this to the 4.1.0 milestone Dec 24, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 24, 2024
@dao-jun dao-jun changed the title [WIP] Make offloader threshold config dynamic [WIP][improve][ml] Make offloader threshold config dynamic Dec 25, 2024
@dao-jun dao-jun closed this Dec 25, 2024
@dao-jun dao-jun deleted the dev/make_offload_threshold-dynamic branch December 25, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ML doc-not-needed Your PR changes do not impact docs type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant