Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][ml] Optimize BlobStoreManagedLedgerOffloader.getOffloadPolicies #23776

Merged

Conversation

dao-jun
Copy link
Member

@dao-jun dao-jun commented Dec 24, 2024

Motivation

Optimize BlobStoreManagedLedgerOffloader.getOffloadPolicies()

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@dao-jun dao-jun requested a review from lhotari December 24, 2024 07:17
@dao-jun dao-jun self-assigned this Dec 24, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 24, 2024
@dao-jun dao-jun added category/performance Performance issues fix or improvements ready-to-test and removed doc-not-needed Your PR changes do not impact docs labels Dec 24, 2024
@dao-jun dao-jun added this to the 4.1.0 milestone Dec 24, 2024
@dao-jun dao-jun closed this Dec 24, 2024
@dao-jun dao-jun reopened this Dec 24, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.14%. Comparing base (bbc6224) to head (b6f6347).
Report is 815 commits behind head on master.

Files with missing lines Patch % Lines
...d/jcloud/impl/BlobStoreManagedLedgerOffloader.java 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23776      +/-   ##
============================================
+ Coverage     73.57%   74.14%   +0.57%     
+ Complexity    32624    31766     -858     
============================================
  Files          1877     1853      -24     
  Lines        139502   143373    +3871     
  Branches      15299    16276     +977     
============================================
+ Hits         102638   106309    +3671     
+ Misses        28908    28687     -221     
- Partials       7956     8377     +421     
Flag Coverage Δ
inttests 26.67% <ø> (+2.08%) ⬆️
systests 23.12% <ø> (-1.20%) ⬇️
unittests 73.67% <83.33%> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...d/jcloud/impl/BlobStoreManagedLedgerOffloader.java 75.79% <83.33%> (+0.61%) ⬆️

... and 1021 files with indirect coverage changes

@nodece nodece merged commit 369c352 into apache:master Dec 25, 2024
77 of 82 checks passed
@dao-jun dao-jun deleted the dev/optimize_blob_offloader_getOffloadPolicies branch December 25, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tieredstorage category/performance Performance issues fix or improvements doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants