Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Fix pulsar.replicated.subscription checks #23782

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nodece
Copy link
Member

@nodece nodece commented Dec 26, 2024

Motivation

Strictly verify pulsar.replicated.subscription value.

Modifications

Enable the subscription replication when only the value pulsar.replicated.subscription is 1L.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 26, 2024
@nodece nodece self-assigned this Dec 26, 2024
@nodece nodece closed this Dec 26, 2024
@nodece nodece reopened this Dec 26, 2024
@nodece
Copy link
Member Author

nodece commented Dec 26, 2024

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.18%. Comparing base (bbc6224) to head (296bde3).
Report is 815 commits behind head on master.

Files with missing lines Patch % Lines
...ker/service/persistent/PersistentSubscription.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23782      +/-   ##
============================================
+ Coverage     73.57%   74.18%   +0.61%     
+ Complexity    32624    31780     -844     
============================================
  Files          1877     1853      -24     
  Lines        139502   143380    +3878     
  Branches      15299    16277     +978     
============================================
+ Hits         102638   106372    +3734     
+ Misses        28908    28640     -268     
- Partials       7956     8368     +412     
Flag Coverage Δ
inttests 26.72% <80.00%> (+2.14%) ⬆️
systests 23.20% <80.00%> (-1.12%) ⬇️
unittests 73.70% <90.00%> (+0.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...sar/broker/service/persistent/PersistentTopic.java 79.73% <100.00%> (+1.27%) ⬆️
...ker/service/persistent/PersistentSubscription.java 77.20% <75.00%> (+0.50%) ⬆️

... and 1022 files with indirect coverage changes

@nodece nodece requested a review from lhotari December 27, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants