Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][test]: naming conventions #23828

Closed
wants to merge 2 commits into from
Closed

Conversation

falser101
Copy link
Contributor

@falser101 falser101 commented Jan 9, 2025

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change added tests

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@falser101 falser101 changed the title fix[test]: naming conventions [fix][test]: naming conventions Jan 9, 2025
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 9, 2025
@falser101
Copy link
Contributor Author

please help review, thanks. @BewareMyPower @poorbarcode @codelipenghui @liangyepianzhou

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recommend starting Pulsar contributions in making such refactoring in tests. This would cause a lot of churn in the code base without much added value. We should first have a broader discussion around test improvements on the dev mailing list and then proceed into action.
@heesung-sn has started such a discussion with PIP-390 #23565, thread is https://lists.apache.org/thread/fn3rk1x7v9291qh3g6vf4jxhvq6zc4mm . You are welcome to participate in the discussion and making the decisions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@falser101 falser101 closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants