[fix][client] Client interceptors close method not called after producer/consumer/reader close #23830
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
close
methods in client interceptors (ProducerInterceptor#close
,ConsumerInterceptor#close
,ReaderInterceptor#close
) allow interceptor developers to release resources allocated in the interceptor when a producer, consumer, or reader is closed.However, these
close
methods were not invoked in the implementation of PIP-23.Modifications
close
methods of interceptors are called during the final stage of the closing process.Verifying this Change
This change includes the following tests:
ProducerInterceptor
with non-partitioned and partitioned topics.ConsumerInterceptor
with non-partitioned and partitioned topics.ConsumerInterceptor
with ZeroQueueConsumerImplReaderInterceptor
with non-partitioned and partitioned topics.Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: Shawyeok#23