[fix][misc]: ignore deleted ledger when tear down cluster #23831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattisonchao
changed the title
dao-jun
reviewed
Jan 10, 2025
| switch (bkException.getCode()) { | ||
| case BKException.Code.NoSuchLedgerExistsException: | ||
| case BKException.Code.NoSuchLedgerExistsOnMetadataServerException: | ||
| case BKException.Code.NoSuchEntryException: |
There was a problem hiding this comment.
LGTM, but why to catch NoSuchEntryException ?
dao-jun
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current tear-down logic is listing ledgers and then deleting them. So, there's a race condition if some internal logic has deleted the schema ledger, which will cause the down process to fail.
Modifications
Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-complete