Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Remove blocking calls from internalGetPartitionedStats #23832

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nodece
Copy link
Member

@nodece nodece commented Jan 9, 2025

Motivation

The metadata-store thread is blocked in the Pulsar 3.0.x:

"metadata-store-11-1" #18 prio=5 os_prio=0 cpu=191.70ms elapsed=92.64s tid=0x00007fe149887e80 nid=0x3f39b waiting on condition  [0x00007fdedd3fd000]
   java.lang.Thread.State: TIMED_WAITING (parking)
	at jdk.internal.misc.Unsafe.park([email protected]/Native Method)
	- parking to wait for  <0x00001000270a2020> (a java.util.concurrent.CompletableFuture$Signaller)
	at java.util.concurrent.locks.LockSupport.parkNanos([email protected]/LockSupport.java:252)
	at java.util.concurrent.CompletableFuture$Signaller.block([email protected]/CompletableFuture.java:1866)
	at java.util.concurrent.ForkJoinPool.unmanagedBlock([email protected]/ForkJoinPool.java:3463)
	at java.util.concurrent.ForkJoinPool.managedBlock([email protected]/ForkJoinPool.java:3434)
	at java.util.concurrent.CompletableFuture.timedGet([email protected]/CompletableFuture.java:1939)
	at java.util.concurrent.CompletableFuture.get([email protected]/CompletableFuture.java:2095)
	at org.apache.pulsar.broker.resources.BaseResources.exists(BaseResources.java:183)
	at org.apache.pulsar.broker.resources.NamespaceResources$PartitionedTopicResources.partitionedTopicExists(NamespaceResources.java:302)
	at org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.lambda$internalGetPartitionedStats$173(PersistentTopicsBase.java:1579)
	at org.apache.pulsar.broker.admin.impl.PersistentTopicsBase$$Lambda$687/0x0000000801261160.apply(Unknown Source)
	at java.util.concurrent.CompletableFuture.uniHandle([email protected]/CompletableFuture.java:934)
	at java.util.concurrent.CompletableFuture.uniHandleStage([email protected]/CompletableFuture.java:950)
	at java.util.concurrent.CompletableFuture.handle([email protected]/CompletableFuture.java:2340)
	at org.apache.pulsar.broker.admin.impl.PersistentTopicsBase.lambda$internalGetPartitionedStats$174(PersistentTopicsBase.java:1560)
	at org.apache.pulsar.broker.admin.impl.PersistentTopicsBase$$Lambda$674/0x00000008012561a0.accept(Unknown Source)

Modifications

Remove blocking calls.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 9, 2025
@nodece nodece force-pushed the fix-internalGetPartitionedStats-block branch from c33b7da to 5b67eeb Compare January 10, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants