[improve] Support overriding java.net.preferIPv4Stack with OPTS #23846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
/pulsarbot rerun-failure-checks |
lhotari
added a commit
that referenced
this pull request
Jan 16, 2025
(cherry picked from commit aff9ec8)
lhotari
added a commit
that referenced
this pull request
Jan 17, 2025
(cherry picked from commit aff9ec8)
poorbarcode
pushed a commit
to poorbarcode/pulsar
that referenced
this pull request
Jan 23, 2025
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 31, 2025
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When using Pulsar with IPv6, it's necessary to set
-Djava.net.preferIPv4Stack=falsesince Pulsar startup scripts set-Djava.net.preferIPv4Stack=true. Currently it's not possible to override the Pulsar default by passing-Djava.net.preferIPv4Stack=falseinOPTSenvironment variable. This PR intends to make it possible.This PR is related to the issue #23843.
Modifications
Prepend the default value
-Djava.net.preferIPv4Stack=truetoOPTSinstead of appending to it so that the setting inOPTStakes preference. The last setting in the argument line wins when setting system properties for Java processes.Documentation
docdoc-requireddoc-not-neededdoc-complete