Skip to content

[fix][test] Fix flaky NegativeAcksTest.testNegativeAcksWithBackoff #24342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[fix][test] Fix flaky NegativeAcksTest.testNegativeAcksWithBackoff #24342

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5cc5faf
[fix][test] Fix flaky NegativeAcksTest.testNegativeAcksWithBackoff
hanmz May 23, 2025
d7eb500
[fix][test] Fix flaky NegativeAcksTest.testNegativeAcksWithBackoff
hanmz May 26, 2025
e69059f
Merge branch 'apache-master' into fix/flaky-testNegativeAcksWithBackoff
hanmz May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions pulsar-broker/src/test/java/org/apache/pulsar/client/impl/NegativeAcksTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@ public void testNegativeAcksWithBackoff(boolean batching, boolean usePartitions,
Producer<String> producer = pulsarClient.newProducer(Schema.STRING)
.topic(topic)
.enableBatching(batching)
.batchingMaxPublishDelay(30, TimeUnit.SECONDS)
.create();

Set<String> sentMessages = new HashSet<>();
Expand All @@ -258,8 +259,9 @@ public void testNegativeAcksWithBackoff(boolean batching, boolean usePartitions,
for (int i = 0; i < redeliverCount; i++) {
Message<String> msg = null;
for (int j = 0; j < N; j++) {
msg = consumer.receive();
log.info("Received message {}", msg.getValue());
msg = consumer.receive(10, TimeUnit.SECONDS);
assertNotNull(msg);
log.info("Received msgId: {}, message {}", msg.getMessageId(), msg.getValue());
if (!batching) {
consumer.negativeAcknowledge(msg);
}
Expand All @@ -275,7 +277,8 @@ public void testNegativeAcksWithBackoff(boolean batching, boolean usePartitions,

// All the messages should be received again
for (int i = 0; i < N; i++) {
Message<String> msg = consumer.receive();
Message<String> msg = consumer.receive(10, TimeUnit.SECONDS);
assertNotNull(msg);
receivedMessages.add(msg.getValue());
consumer.acknowledge(msg);
}
Expand Down
Loading