Make PulsarStandaloneBuilder a public API (#10473) #24781
+59
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added convenience methods to build PulsarClient and PulsarAdmin - Enabled starting the server without creating real files on disk - Added unit tests to ensure usage via Java program
lhotari
reviewed
Sep 27, 2025
Comment on lines
+120
to
+121
| Path tempZkDir = Files.createTempDirectory("zk"); | ||
| Path tempBkDir = Files.createTempDirectory("bk"); |
There was a problem hiding this comment.
These files would be left around in the temp directories. wipeData currently wipes data only at startup time.
There was a problem hiding this comment.
These directories would also be created when it's not desired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PulsarClientandPulsarAdmin.Fixes: #10473
Motivation
Make
PulsarStandaloneBuilderusable as a public API for unit tests, without requiring Docker/Testcontainers.Modifications
buildClient()andbuildAdmin()methods.PulsarStandaloneBuilderTest.javaunit test.Verifying this change
mvn testto ensure all unit tests pass, includingPulsarStandaloneBuilderTest.Does this pull request potentially affect one of the following parts:
Documentation
doc-not-needed