[fix][client] Fix thread leak in reloadLookUp method which is used by ServiceUrlProvider #24794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ServiceUrlProvider
lhotari
added
type/bug
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24794 +/- ##
============================================
- Coverage 74.27% 74.18% -0.09%
+ Complexity 33676 33295 -381
============================================
Files 1907 1907
Lines 148703 148708 +5
Branches 17249 17249
============================================
- Hits 110443 110324 -119
- Misses 29439 29569 +130
+ Partials 8821 8815 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
nodece
reviewed
Sep 28, 2025
| } | ||
|
|
||
| public void reloadLookUp() throws PulsarClientException { | ||
| if (lookup != null) { |
There was a problem hiding this comment.
@lhotari The lookup variable is not declared as volatile, which may lead to a visibility issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
LookupService is replaced by calling reloadLookUp. However the previous instance is not closed. This causes a thread leak.
Modifications
Call the close method before replacing LookupService.
Documentation
docdoc-requireddoc-not-neededdoc-complete