[improve][broker] Part-3 of PIP-434: add configurations to broker.conf #24800
+62
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dao-jun
approved these changes
Sep 29, 2025
Technoboy-
reviewed
Sep 30, 2025
|
|
||
| # It relates to configuration "WriteBufferHighWaterMark" of Netty Channel Config. If the number of bytes | ||
| # queued in the write buffer exceeds this value, channel writable state will start to return "false". | ||
| pulsarChannelWriteBufferHighWaterMark=65536 |
There was a problem hiding this comment.
Why is this field not named nettyChannelWriteBufferHighWaterMark?
There was a problem hiding this comment.
Because the pip-434 defined it, which is different from bk_client params
coderzc
approved these changes
Sep 30, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #24800 +/- ##
=============================================
+ Coverage 38.67% 74.15% +35.48%
- Complexity 13237 33363 +20126
=============================================
Files 1850 1911 +61
Lines 144540 149033 +4493
Branches 16763 17294 +531
=============================================
+ Hits 55895 110522 +54627
+ Misses 81156 29667 -51489
- Partials 7489 8844 +1355
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See the PIP-434
Modifications
broker.confDocumentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x