Skip to content

[fix][build] Remove commons-collections:commons-collections references #24818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −7
Open

[fix][build] Remove commons-collections:commons-collections references #24818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f2fffa
Remove commons-collections:commons-collections references from source…
Sep 30, 2025
77e563c
Unshade bookkeeper from pulsar-client jars
Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedCursorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
import org.apache.bookkeeper.mledger.proto.MLDataFormats.PositionInfo;
import org.apache.bookkeeper.mledger.util.ManagedLedgerUtils;
import org.apache.bookkeeper.test.MockedBookKeeperTestCase;
import org.apache.commons.collections.iterators.EmptyIterator;
import org.apache.commons.collections4.iterators.EmptyIterator;
import org.apache.commons.lang3.mutable.MutableBoolean;
import org.apache.pulsar.common.api.proto.CommandSubscribe;
import org.apache.pulsar.common.api.proto.IntRange;
Expand Down
2 changes: 0 additions & 2 deletions pulsar-client-admin-shaded/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@
<include>com.yahoo.datasketches:sketches-core</include>
<include>commons-*:*</include>
<include>commons-codec:commons-codec</include>
<include>commons-collections:commons-collections</include>
<include>io.airlift:*</include>
<include>io.grpc:*</include>
<include>io.netty.incubator:*</include>
Expand All @@ -143,7 +142,6 @@
<include>javax.ws.rs:*</include>
<include>javax.xml.bind:jaxb-api</include>
<include>net.jcip:jcip-annotations</include>
<include>org.apache.bookkeeper:*</include>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be replaced with

<include>org.apache.bookkeeper:bookkeeper-common-allocator</include>
<include>org.apache.bookkeeper:cpu-affinity</include>
<include>org.apache.bookkeeper:circe-checksum</include>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this line might not even be needed since I'd assume that it would work correctly since test dependencies won't get included in the shaded jar.

<include>org.apache.commons:commons-compress</include>
<include>org.apache.commons:commons-lang3</include>
<include>org.apache.pulsar:pulsar-client-admin-original</include>
Expand Down
2 changes: 0 additions & 2 deletions pulsar-client-all/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,6 @@
<include>com.yahoo.datasketches:sketches-core</include>
<include>commons-*:*</include>
<include>commons-codec:commons-codec</include>
<include>commons-collections:commons-collections</include>
<include>io.airlift:*</include>
<include>io.grpc:*</include>
<include>io.netty.incubator:*</include>
Expand All @@ -192,7 +191,6 @@
<include>javax.xml.bind:jaxb-api</include>
<include>net.jcip:jcip-annotations</include>
<include>org.apache.avro:*</include>
<include>org.apache.bookkeeper:*</include>
<include>org.apache.commons:commons-compress</include>
<include>org.apache.commons:commons-lang3</include>
<include>org.apache.pulsar:pulsar-client-admin-original</include>
Expand Down
2 changes: 0 additions & 2 deletions pulsar-client-shaded/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@
<include>com.yahoo.datasketches:sketches-core</include>
<include>commons-*:*</include>
<include>commons-codec:commons-codec</include>
<include>commons-collections:commons-collections</include>
<include>io.airlift:*</include>
<include>io.netty.incubator:*</include>
<include>io.netty:*</include>
Expand All @@ -160,7 +159,6 @@
<include>javax.ws.rs:*</include>
<include>net.jcip:jcip-annotations</include>
<include>org.apache.avro:*</include>
<include>org.apache.bookkeeper:*</include>
<include>org.apache.commons:commons-compress</include>
<include>org.apache.commons:commons-lang3</include>
<!-- Issue #6834, Since Netty ByteBuf shaded, we need also shade this module -->
Expand Down
Loading