make the json format of ConsumeRunningInfo and HeartBeatData compatible with RocketMQ Java main project #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humkum
force-pushed
the
sub-detail
branch
2 times, most recently
from
ec0e6a8
to
35c1f4c
Compare
…le with RocketMQ Java main project
ifplusor
reviewed
Jun 22, 2022
Comment on lines
106
to
+118
| string key = "\"mqTable\":"; | ||
| key.append("{"); | ||
| key.append("["); | ||
| for (map<MessageQueue, ProcessQueueInfo>::iterator it = mqTable.begin(); it != mqTable.end(); ++it) { | ||
| key.append("["); | ||
| key.append((it->first).toJson().toStyledString()); | ||
| key.erase(key.end() - 1); | ||
| key.append(":"); | ||
| key.append(","); | ||
| key.append((it->second).toJson().toStyledString()); | ||
| key.append("]"); | ||
| key.append(","); | ||
| } | ||
| key.erase(key.end() - 1); | ||
| key.append("}"); | ||
| key.append("]"); |
There was a problem hiding this comment.
The type of mqTable in Java is TreeMap<MessageQueue, ProcessQueueInfo>, but you marshall it to a list, how does it work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
#402
Brief changelog
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.