Fix crash issue of TelemetryBidiReactor and MetricBidiReactor (#809)

* Fix crash issue of TelemetryBidiReactor and MetricBidiReactor * Update TelemetryBidiReactor.cpp * Update TelemetryBidiReactor.h * fix: remove macos-11 as there is no runner of this type available Signed-off-by: Zhanhui Li <[email protected]> --------- Signed-off-by: Zhanhui Li <[email protected]> Co-authored-by: Zhanhui Li <[email protected]>
apache · Aug 6, 2024 · a363f41 · a363f41
1 parent b4a47a9
commit a363f41
Show file tree

Hide file tree

Showing 7 changed files with 104 additions and 313 deletions.
diff --git a/.github/workflows/cpp_build.yml b/.github/workflows/cpp_build.yml
@@ -9,8 +9,9 @@ jobs:
       fail-fast: false
       matrix:
         # Disable VS 2022 before https://github.com/bazelbuild/bazel/issues/18592 issue is solved
+        # Remove macos-11 since there is no such runner available
         # os: [ubuntu-20.04, ubuntu-22.04, macos-11, macos-12, windows-2019, windows-2022]
-        os: [ubuntu-20.04, ubuntu-22.04, macos-11, macos-12, windows-2019]
+        os: [ubuntu-20.04, ubuntu-22.04, macos-12, windows-2019]
     steps:
       - uses: actions/checkout@v2
       - name: Compile On Linux

diff --git a/cpp/source/client/SessionImpl.cpp b/cpp/source/client/SessionImpl.cpp
@@ -29,7 +29,7 @@ SessionImpl::SessionImpl(std::weak_ptr<Client> client, std::shared_ptr<RpcClient
 }
 
 bool SessionImpl::await() {
-  return telemetry_->await();
+  return telemetry_->awaitApplyingSettings();
 }
 
 void SessionImpl::syncSettings() {
@@ -41,7 +41,7 @@ void SessionImpl::syncSettings() {
 }
 
 SessionImpl::~SessionImpl() {
-  telemetry_->fireClose();
+  telemetry_->close();
   SPDLOG_DEBUG("Session for {} destructed", rpc_client_->remoteAddress());
 }