(golang) give a random index for NewSubscriptionLoadBalancer #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingkh1995
changed the title
kingkh1995
force-pushed
the
fix-go-loadbalancer
branch
from
ba8da97
to
2d3cdf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #655
Brief Description
If use SimpleConsumer for consumption, due to the invalidation of the TopicRoute in the subTopicRouteDataResultCache, the SubscriptionLoadBalancer will be recreated, because the index is not given a random value (a random value is given in the Java client), the index always starts from 0, If the awaitDuration value is set too large, You may never be able to pull a message from a queue that is lower in order.
How Did You Test This Change?
I'm no Go expert, please help me improve my code if need.