Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golang: Add namespace in Resource and metadata #753

Merged
merged 2 commits into from
May 16, 2024
Merged

golang: Add namespace in Resource and metadata #753

merged 2 commits into from
May 16, 2024

Conversation

guyinyou
Copy link
Contributor

Add namespace in Resource and metadata

@drpmma
Copy link
Contributor

drpmma commented May 15, 2024

Please add some unit test.

@guyinyou
Copy link
Contributor Author

Please add some unit test.

done

drpmma
drpmma approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RongtongJin RongtongJin merged commit 5790fc4 into apache:master May 16, 2024
15 of 16 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drpmma drpmma drpmma approved these changes

@RongtongJin RongtongJin RongtongJin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guyinyou @drpmma @RongtongJin