-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #826] Add RmqSinkTask #827
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first,the origin design is use the target cluster as connector host cluster,In this way, messages can be directly synchronized to another cluster without going through a sink task, and a native format converter is provided in the replicator
First of all, thank you for your answer. What you mean is that the read message is directly written to the local cluster (while serving as the target cluster) through RocketMQConverter. I also agree with this approach. My original intention of adding WorkerDirectTask and RmqSinkTask was to follow the design philosophy of openmessage and reduce intermediate storage. Do you think it makes sense? |
0122d23
to
05a29ec
Compare
Signed-off-by: zhangyang21 <[email protected]>
05a29ec
to
b5f79d8
Compare
Message msg = new Message(); | ||
msg.setTopic(topic); | ||
msg.setBody(msgBody.getBytes(StandardCharsets.UTF_8)); | ||
msg.setKeys(String.format("%s %s %s", offsetMsgId, clientMsgId, keys)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The offsetMsgId is added to the keys, which can be used for message offset checking.
What is the purpose of the change
#826
Brief changelog
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.