Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Tiered storage may cause commitLog undeleted once dispatch was held #8334

Open
3 tasks done
bxfjb opened this issue Jun 27, 2024 · 0 comments · May be fixed by #8335
Open
3 tasks done

[Bug] Tiered storage may cause commitLog undeleted once dispatch was held #8334

bxfjb opened this issue Jun 27, 2024 · 0 comments · May be fixed by #8335

Comments

@bxfjb
Copy link
Contributor

bxfjb commented Jun 27, 2024

Before Creating the Bug Report

  • I found a bug, not just asking a question, which should be created in GitHub Discussions.

  • I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.

  • I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment

Any

RocketMQ version

develop

JDK Version

1.8

Describe the Bug

  • The bug was found under dledger mode and it should reproduce under normal commitLog.
  • The MessageDispatcherImpl didn't release the refCount of mapped file (DefaultMappedFile or DefaultMmapFile) correctly when diapatch was held, which may cause the refered commitLog undeleted.

Steps to Reproduce

  • Enable tiered store, produce message under low rate which cause MessageDispatcher#dispatch hold at least once.
  • When CleanCommitLogService#deleteExpiredFiles deleting the held file, the log highlighted below should be shown.
    image

What Did You Expect to See?

The expired commitLog should be deleted correctly.

What Did You See Instead?

Unexpected warn log.
image

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant