Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8334] fix: irreducible reference count of mapped file caused by held tiered storage's dispatch #8335

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

bxfjb
Copy link
Contributor

@bxfjb bxfjb commented Jun 27, 2024

Which Issue(s) This PR Fixes

Fixes #8334

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 12 lines in your changes missing coverage. Please review.

Project coverage is 43.16%. Comparing base (b31e0ce) to head (c9d68d6).

Files Patch % Lines
...q/tieredstore/core/MessageStoreDispatcherImpl.java 40.00% 7 Missing and 5 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8335      +/-   ##
=============================================
- Coverage      43.19%   43.16%   -0.04%     
+ Complexity     10523    10513      -10     
=============================================
  Files           1274     1274              
  Lines          88940    88945       +5     
  Branches       11434    11435       +1     
=============================================
- Hits           38422    38391      -31     
- Misses         45811    45833      +22     
- Partials        4707     4721      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Tiered storage may cause commitLog undeleted once dispatch was held
3 participants