Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6910] Extract the interval of fetchNameServerAddr #6912

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

totalo
Copy link
Member

@totalo totalo commented Jun 16, 2023

Fix #6910

@totalo totalo changed the title refactor:Extract the interval of fetchNameServerAddr refactor:extract the interval of fetchNameServerAddr Jun 16, 2023
@RongtongJin RongtongJin changed the title refactor:extract the interval of fetchNameServerAddr [ISSUE #6910] Extract the interval of fetchNameServerAddr Jun 17, 2023
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@totalo Use fix #xxxx to link issue

@totalo
Copy link
Member Author

totalo commented Jun 19, 2023

@totalo Use fix #xxxx to link issue

done.

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #6912 (a4f8372) into develop (4e09a9c) will increase coverage by 0.04%.
The diff coverage is 40.00%.

@@              Coverage Diff              @@
##             develop    #6912      +/-   ##
=============================================
+ Coverage      42.61%   42.65%   +0.04%     
- Complexity      9173     9185      +12     
=============================================
  Files           1131     1131              
  Lines          80225    80227       +2     
  Branches       10469    10465       -4     
=============================================
+ Hits           34184    34222      +38     
+ Misses         41767    41732      -35     
+ Partials        4274     4273       -1     
Impacted Files Coverage Δ
...a/org/apache/rocketmq/broker/BrokerController.java 43.97% <0.00%> (ø)
...ava/org/apache/rocketmq/common/BrokerIdentity.java 40.67% <ø> (ø)
...org/apache/rocketmq/container/BrokerContainer.java 53.48% <0.00%> (-0.25%) ⬇️
.../java/org/apache/rocketmq/common/BrokerConfig.java 27.30% <25.00%> (-0.02%) ⬇️
...ache/rocketmq/container/BrokerContainerConfig.java 89.65% <75.00%> (-2.35%) ⬇️

... and 23 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RongtongJin RongtongJin merged commit 5d6ee63 into apache:develop Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Extract the interval of fetchNameServerAddr
4 participants