[ISSUE #6957] Support Proxy Protocol for gRPC and Remoting server #6958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity of ProtocolNegotiator
…ity of ProtocolNegotiator
… scalability of ProtocolNegotiator
… scalability of ProtocolNegotiator
… scalability of ProtocolNegotiator
… scalability of ProtocolNegotiator
mxsm
reviewed
Jun 28, 2023
RongtongJin
reviewed
Jun 28, 2023
remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingServer.java
Outdated
Show resolved
Hide resolved
RongtongJin
reviewed
Jun 28, 2023
lizhimins
reviewed
Jun 29, 2023
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/interceptor/HeaderInterceptor.java
Show resolved
Hide resolved
lizhimins
reviewed
Jun 29, 2023
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/interceptor/HeaderInterceptor.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/interceptor/HeaderInterceptor.java
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6958 +/- ##
=============================================
- Coverage 42.68% 42.66% -0.03%
- Complexity 9236 9239 +3
=============================================
Files 1133 1136 +3
Lines 80492 80635 +143
Branches 10515 10538 +23
=============================================
+ Hits 34362 34404 +42
- Misses 41834 41927 +93
- Partials 4296 4304 +8 ☔ View full report in Codecov by Sentry. |
lizhimins
approved these changes
Jul 4, 2023
lizhimins
pushed a commit
to lizhimins/rocketmq
that referenced
this pull request
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #6957
Brief Description
When the RocketMQ client accesses the RocketMQ server through multiple layers of NAT or TCP proxies, the server is unable to obtain the actual IP address information of the client. In such cases, the HAProxy's Proxy protocol can be introduced to transparently pass the initial TCP connection information of the client. This allows the server to accurately identify the source of message production and consumption.
How Did You Test This Change?
I have applied for a proxy service that supports the transparent transmission of the Proxy Protocol. The client sends requests to the server through this proxy service. The server successfully retrieves the Proxy Protocol data and extracts the client's real IP address from it. The server then sets this IP address in the message's attributes.