Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data block configuration and simplify code #8253

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

lby1119
Copy link

@lby1119 lby1119 commented Jun 4, 2024

Add data block configuration and simplify code

@yx9o
Copy link
Contributor

yx9o commented Jun 6, 2024

Hi @lby1119 , it would be better to submit a relevant issue first.

@lby1119
Copy link
Author

lby1119 commented Jun 6, 2024

@yx9o Okay, I'll add it later.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 6.25000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 42.88%. Comparing base (af43a3e) to head (d0e52bc).
Report is 40 commits behind head on develop.

Files Patch % Lines
...org/apache/rocketmq/store/DefaultMessageStore.java 0.00% 12 Missing ⚠️
...ache/rocketmq/store/config/MessageStoreConfig.java 25.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8253      +/-   ##
=============================================
- Coverage      42.89%   42.88%   -0.01%     
- Complexity     10364    10368       +4     
=============================================
  Files           1270     1271       +1     
  Lines          88681    88791     +110     
  Branches       11397    11410      +13     
=============================================
+ Hits           38042    38081      +39     
- Misses         45949    45996      +47     
- Partials        4690     4714      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants