Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8780] Implement asynchronous storage of ack/ck messages in pop consume to enhance performance #8727

Merged
merged 6 commits into from
Oct 16, 2024

Conversation

RongtongJin
Copy link
Contributor

@RongtongJin RongtongJin commented Sep 21, 2024

Which Issue(s) This PR Fixes

Fixes #8780

Brief Description

Implement asynchronous storage of ack/ck messages in pop consume to enhance performance

How Did You Test This Change?

@RongtongJin RongtongJin marked this pull request as draft September 21, 2024 14:23
@RongtongJin RongtongJin changed the title [DRFAT] Pop consume asynchronization [DRFAT] Implement asynchronous storage of ack/ck messages in pop consumption to enhance performance Sep 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 23.92638% with 124 lines in your changes missing coverage. Please review.

Project coverage is 47.32%. Comparing base (0d6c94b) to head (b6e0907).
Report is 21 commits behind head on develop.

Files with missing lines Patch % Lines
...cketmq/broker/processor/PopBufferMergeService.java 5.66% 50 Missing ⚠️
...broker/processor/ChangeInvisibleTimeProcessor.java 33.33% 35 Missing and 7 partials ⚠️
.../apache/rocketmq/broker/failover/EscapeBridge.java 30.00% 12 Missing and 2 partials ⚠️
...rocketmq/broker/processor/AckMessageProcessor.java 29.41% 11 Missing and 1 partial ⚠️
.../java/org/apache/rocketmq/common/BrokerConfig.java 25.00% 6 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8727      +/-   ##
=============================================
- Coverage      47.54%   47.32%   -0.22%     
- Complexity     11551    11565      +14     
=============================================
  Files           1279     1283       +4     
  Lines          89558    89964     +406     
  Branches       11514    11566      +52     
=============================================
- Hits           42581    42578       -3     
- Misses         41747    42129     +382     
- Partials        5230     5257      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin RongtongJin changed the title [DRFAT] Implement asynchronous storage of ack/ck messages in pop consumption to enhance performance [DRFAT] Implement asynchronous storage of ack/ck messages in pop consume to enhance performance Sep 22, 2024
@RongtongJin RongtongJin changed the title [DRFAT] Implement asynchronous storage of ack/ck messages in pop consume to enhance performance [ISSUE #8780] Implement asynchronous storage of ack/ck messages in pop consume to enhance performance Oct 3, 2024
@RongtongJin RongtongJin marked this pull request as ready for review October 8, 2024 02:16
Copy link
Contributor

@fuyou001 fuyou001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@guyinyou guyinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@GenerousMan GenerousMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonDing ShannonDing merged commit 4f5f705 into apache:develop Oct 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Implement asynchronous storage of ack/ck messages in pop consume to enhance performance
6 participants