Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8736] fix searchOffset corner case in rocksdb consume queue #8737

Merged
merged 10 commits into from
Sep 29, 2024

Conversation

yuz10
Copy link
Member

@yuz10 yuz10 commented Sep 24, 2024

Which Issue(s) This PR Fixes

Fixes #8736

treat the corner case, following the code:
https://github.com/apache/rocketmq/blob/develop/store/src/main/java/org/apache/rocketmq/store/ConsumeQueue.java#L240

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 47.38%. Comparing base (525f877) to head (ad3431c).

Files with missing lines Patch % Lines
...rocketmq/store/queue/RocksDBConsumeQueueTable.java 62.50% 2 Missing and 4 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8737      +/-   ##
=============================================
- Coverage      47.48%   47.38%   -0.10%     
+ Complexity     11568    11559       -9     
=============================================
  Files           1282     1282              
  Lines          89813    89829      +16     
  Branches       11553    11559       +6     
=============================================
- Hits           42646    42565      -81     
- Misses         41935    42006      +71     
- Partials        5232     5258      +26     
Flag Coverage Δ
47.38% <62.50%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lizhanhui lizhanhui merged commit 551c8c3 into apache:develop Sep 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] searchLowerBoundaryOffset returns -1 in rocksdb consumeQueue
3 participants