Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8942] Add incGroupAckNums and incGroupCkNums to LmqBrokerStatsManager #8943

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

RongtongJin
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #8942

  • Add incGroupAckNums and incGroupCkNums to LmqBrokerStatsManager
  • Add a setBrokerStatsManager method to enhance extensibility, allowing for more fine-grained control to be implemented externally.
    Alternatively, we could discuss the removal of the LmqBrokerStatsManager class, as it appears to have limited value in my opinion.

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 47.54%. Comparing base (4574647) to head (04d2724).

Files with missing lines Patch % Lines
...he/rocketmq/store/stats/LmqBrokerStatsManager.java 0.00% 16 Missing ⚠️
...a/org/apache/rocketmq/broker/BrokerController.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #8943   +/-   ##
==========================================
  Coverage      47.53%   47.54%           
+ Complexity     11731    11730    -1     
==========================================
  Files           1304     1304           
  Lines          91058    91076   +18     
  Branches       11675    11679    +4     
==========================================
+ Hits           43288    43305   +17     
+ Misses         42426    42422    -4     
- Partials        5344     5349    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add incGroupAckNums and incGroupCkNums to LmqBrokerStatsManager
4 participants