Skip to content

[ISSUE #9741] Optimize authorization whitelist lookup efficiency #9760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

[ISSUE #9741] Optimize authorization whitelist lookup efficiency #9760

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3cbcd82
[ISSUE #9741] Optimize authorization whitelist lookup efficiency
majialoong Oct 15, 2025
a8d58c0
Remove unused import
majialoong Oct 15, 2025
002d232
Fix get authorization metadata provider.
majialoong Oct 15, 2025
c908a8c
Merge remote-tracking branch 'upstream/develop' into ISSUE-9741
majialoong Oct 16, 2025
520ce4d
Merge remote-tracking branch 'upstream/develop' into ISSUE-9741
majialoong Oct 22, 2025
8040bef
Merge remote-tracking branch 'upstream/develop' into ISSUE-9741
majialoong Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...n/java/org/apache/rocketmq/auth/authorization/strategy/AbstractAuthorizationStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
*/
package org.apache.rocketmq.auth.authorization.strategy;

import java.util.ArrayList;
import java.util.List;
import java.util.HashSet;
import java.util.Set;
import java.util.function.Supplier;
import org.apache.commons.lang3.StringUtils;
import org.apache.rocketmq.auth.authorization.context.AuthorizationContext;
Expand All @@ -30,7 +30,7 @@
public abstract class AbstractAuthorizationStrategy implements AuthorizationStrategy {

protected final AuthConfig authConfig;
protected final List<String> authorizationWhitelist = new ArrayList<>();
protected final Set<String> authorizationWhiteSet = new HashSet<>();
protected final AuthorizationProvider<AuthorizationContext> authorizationProvider;

public AbstractAuthorizationStrategy(AuthConfig authConfig, Supplier<?> metadataService) {
Expand All @@ -42,7 +42,7 @@ public AbstractAuthorizationStrategy(AuthConfig authConfig, Supplier<?> metadata
if (StringUtils.isNotBlank(authConfig.getAuthorizationWhitelist())) {
String[] whitelist = StringUtils.split(authConfig.getAuthorizationWhitelist(), ",");
for (String rpcCode : whitelist) {
this.authorizationWhitelist.add(StringUtils.trim(rpcCode));
this.authorizationWhiteSet.add(StringUtils.trim(rpcCode));
}
}
}
Expand All @@ -57,7 +57,7 @@ public void doEvaluate(AuthorizationContext context) {
if (this.authorizationProvider == null) {
return;
}
if (this.authorizationWhitelist.contains(context.getRpcCode())) {
if (this.authorizationWhiteSet.contains(context.getRpcCode())) {
return;
}
try {
Expand Down
Loading