Skip to content

Conversation

@sinberCS
Copy link

@sinberCS sinberCS commented Nov 3, 2025

Change-Id: I4657ecc401046a3b0d29b466ee68845f45d34105

Which Issue(s) This PR Fixes

Fixes #9779

Brief Description

use
PlatformDependent.directBufferAddress(mappedByteBuffer)
replace
((DirectBuffer) mappedByteBuffer).address()

How Did You Test This Change?

…cause error at 9+ JDK version'.

Change-Id: I4657ecc401046a3b0d29b466ee68845f45d34105
RongtongJin
RongtongJin previously approved these changes Nov 4, 2025
Copy link
Contributor

@guyinyou guyinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

…cause error at 9+ JDK version'.

Change-Id: Iff0880f694cccfa86b812b81260dfe09e4763fa9
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.31%. Comparing base (d7c8bb7) to head (01147ca).

Files with missing lines Patch % Lines
...main/java/org/apache/rocketmq/store/CommitLog.java 0.00% 2 Missing ⚠️
.../org/apache/rocketmq/store/TransientStorePool.java 0.00% 2 Missing ⚠️
...ache/rocketmq/store/logfile/DefaultMappedFile.java 33.33% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9801      +/-   ##
=============================================
- Coverage      48.40%   48.31%   -0.10%     
+ Complexity     12263    12237      -26     
=============================================
  Files           1314     1314              
  Lines          93670    93670              
  Branches       12012    12012              
=============================================
- Hits           45343    45253      -90     
- Misses         42724    42823      +99     
+ Partials        5603     5594       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] When dataReadAheadEnable is set to false, there will be problems running on higher JDK versions

4 participants