Skip to content

Conversation

@majialoong
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #9832

Brief Description

Clean up test directories in some RocksDB unit tests

How Did You Test This Change?

unit test and local test

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.28%. Comparing base (e4170f5) to head (afa11f0).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9833      +/-   ##
=============================================
- Coverage      48.35%   48.28%   -0.08%     
+ Complexity     12255    12239      -16     
=============================================
  Files           1314     1314              
  Lines          93777    93777              
  Branches       12034    12034              
=============================================
- Hits           45345    45279      -66     
- Misses         42834    42886      +52     
- Partials        5598     5612      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@After
public void shutdown() throws IOException {
if (consumerService != null) {
consumerService.shutdown();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用例里面已经 shutdown 过了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@majialoong majialoong requested a review from lizhimins November 11, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Cleanup test directories in some RocksDB unit tests

3 participants