[Feature][connectors-v2]File support quote char and escape char #10185
+423
−171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Contributor
|
The parameter has been added to the document, but it seems that FtpFileSourceFactory has been omitted. Do we need to add it? |
Contributor
Author
This is my negligence,I will add. |
Contributor
Author
added |
yzeng1618
reviewed
Dec 16, 2025
| } | ||
| if (StringUtils.isNotEmpty(escapeChar)) { | ||
| builder.setEscape(escapeChar.charAt(0)); | ||
| } |
Contributor
There was a problem hiding this comment.
Do we need to verify the length? No error will be reported if a mismatch occurs, for example: quote_char="||".
Contributor
There was a problem hiding this comment.
Sorry, this comment was added together with the one from this morning. I didn’t notice it was in pending status and just submitted it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
incompatible-changes.mdto describe the incompatibility caused by this PR.