[Feature][Connector-V2] Support `` for the SQL To Paimon converter #10206
+32
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chl-wxp
approved these changes
Dec 19, 2025
| public void testPiamonQuoteIdentifier() { | ||
| String query = | ||
| "SELECT `decimal_col`, `int_col`, `char_col`, `timestamp_col`, `boolean_col` FROM table WHERE `int_col` > 3 OR `double_col` < 6.6 "; | ||
|
|
Contributor
There was a problem hiding this comment.
Can you add another field without the quote symbol as a comparative test, such as boolean_col
| columnNames.stream() | ||
| .mapToInt( | ||
| columnName -> { | ||
| String fieldName = columnName.replace("`", ""); |
Contributor
There was a problem hiding this comment.
FYI, can you extract a method from columnName.replace("`", ""), such as the method name "extendedSupport()", and then put other supported characters into this method later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
incompatible-changes.mdto describe the incompatibility caused by this PR.