-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[Fix][Connector-V2] Await privilege grant to fix flaky Paimon tests #9818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
cc @hawk9821 as well. |
tableIdentifier); | ||
} | ||
break; | ||
default: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,why was only SELECT/INSERT checked here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, the tests only check for insert and select privileges. I thought it would be fine to add checks for other privileges when we introduce corresponding tests for them. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, the tests only check for insert and select privileges. I thought it would be fine to add checks for other privileges when we introduce corresponding tests for them. What do you think?
@dybyte Sure, but it would be better if we could improve it when adding methods. See your schedule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks for the suggestion!
The grant operation of Paimon is synchronous, and this behavior is quite unusual. I think we should pay attention to why the job does not exit (fail fast) after throw exception. |
@hawk9821 Should we create another issue to track it? Does it block on this PR be merged? |
Yes, we can fix it first and analyze the cause of the problem as a separate issue |
I’m not entirely certain why the permission check still throws an exception even after the retry. However, it seems that the reason the job does not terminate afterward may be related to #9749 . Typically, tests verify behavior with assertions after the job has successfully completed. In this particular case, however, an exception occurs during the job execution itself. As a result, the job is likely not removed from For more details, please see the end of this log:
This is just my hypothesis based on the logs, please correct me if I’m wrong. |
After reviewing the CI logs again I noticed Slow operation detected messages for |
If it's the problem you mentioned, not only does Paimon have this issue, but many places have the same problem? Can we reproduce this problem? Or should we wait until # 9749 is merged before verifying? |
Since this only happens occasionally in CI, it's hard to pinpoint the exact cause. |
We can waiting #9749 be merged, then see what would happend in this case. |
Purpose of this pull request
The Paimon connectors CI occasionally fails. In these cases, the tests hang until they timeout, which can take up to 2 hours and is a very cumbersome issue. The failure occurs because the jobs attempt to access the database before the necessary privileges have been granted.
Example error logs:
To address this, a utility class has been added to ensure that the required database privileges are granted before job execution. This should prevent the flaky test behavior and avoid long-running test hang-ups.
For details, see: https://github.com/dybyte/seatunnel/actions/runs/17436786971/job/49509156864
Does this PR introduce any user-facing change?
No
How was this patch tested?
Covered by existing test
Check list
New License Guide