[Feature] [Connector-V2] [IoTDB] Added source and sink connectors to support IoTDB 2.X #9872
Conversation
…leCompression in tableSession
github-actions
bot
added
document
core
|
|
||
| | 数据源 | 支持的版本 | 地址 | | ||
| |-------|------------------------------|----------------| | ||
| | IoTDB | `0.13.0 <= version <= 1.3.X` | localhost:6667 | |
| sinkConfig.setEnableRPCCompression( | ||
| pluginConfig.get(IoTDBSinkOptions.ENABLE_RPC_COMPRESSION)); | ||
| if (pluginConfig.getOptional(IoTDBSinkOptions.CONNECTION_TIMEOUT_IN_MS).isPresent()) { | ||
| checkNotNull(sinkConfig.getEnableRPCCompression()); |
|
|
||
| try { | ||
| if (session != null) { | ||
| session.close(); |
There was a problem hiding this comment.
flush method exception, which can result in the inability to shut down resources
|
@zhangshenghang Hi, thank you for your review and suggestions! I’ve addressed the changes. Could you please take another look? |
| } else { | ||
| session.insertRecords( | ||
| batchRecords.getDeviceIds(), | ||
| batchRecords.getTimestamps(), |
There was a problem hiding this comment.
Should there be a break in this for clause?
| for (int i = 0; i <= maxRetries; i++) { | ||
| try { |
There was a problem hiding this comment.
The same with last for clause
|
Please paste the result picture of your local running to check the accuracy. For example, using this task config file |
thanks @LJW21-02 ，you can solve the CI failure first, if you think the code is fine, you can try CI again a few times |
Purpose of this pull request
This pull request adds both source and sink connectors to support IoTDB version >= 2.X.
Does this PR introduce any user-facing change?
No
How was this patch tested?
e2e tests
Check list
New License Guide