Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove all databases in proxy before restore #485

Merged
merged 3 commits into from
Dec 28, 2023
Merged

feat: remove all databases in proxy before restore #485

merged 3 commits into from
Dec 28, 2023

Conversation

mlycore
Copy link
Contributor

@mlycore mlycore commented Dec 28, 2023 •
edited
Loading

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Remove all existing databases in ShardingSphere Proxy before executing pitr restore.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?

@mlycore mlycore added this to the 0.4.0 milestone Dec 28, 2023
@mlycore mlycore added pitr solutions of pitr type: enhancement New feature or request labels Dec 28, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 28, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@zhaojinchao95 zhaojinchao95 merged commit f5de34e into apache:main Dec 28, 2023
7 checks passed
@mlycore mlycore deleted the pitr-delete-db branch December 28, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaojinchao95 zhaojinchao95 zhaojinchao95 approved these changes

Assignees
No one assigned
Labels
pitr solutions of pitr type: enhancement New feature or request
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mlycore @zhaojinchao95