perf(logging): Optimize the performance of log collection (#5931)

- Adjust the serialization timing of the request body and response body to avoid unnecessary string operations. - Perform string conversion only after confirming the need to record logs to reduce resource consumption. Co-authored-by: 宗杰 <[email protected]>
apache · Feb 13, 2025 · 5bd78ff · 5bd78ff
1 parent e1a48a1
commit 5bd78ff
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.../src/main/java/org/apache/shenyu/plugin/logging/common/body/LoggingServerHttpRequest.java b/.../src/main/java/org/apache/shenyu/plugin/logging/common/body/LoggingServerHttpRequest.java
@@ -56,11 +56,11 @@ public Flux<DataBuffer> getBody() {
             }
         }).doFinally(signal -> {
             int size = writer.size();
-            String body = writer.output();
             boolean requestBodyTooLarge = LogCollectConfigUtils.isRequestBodyTooLarge(size);
             if (size == 0 || requestBodyTooLarge) {
                 return;
             }
+            String body = writer.output();
             logInfo.setRequestBody(body);
         });
     }

diff --git a/...src/main/java/org/apache/shenyu/plugin/logging/common/body/LoggingServerHttpResponse.java b/...src/main/java/org/apache/shenyu/plugin/logging/common/body/LoggingServerHttpResponse.java
@@ -171,8 +171,8 @@ private void logResponse(final ShenyuContext shenyuContext, final BodyWriter wri
         }
         if (Objects.nonNull(writer)) {
             int size = writer.size();
-            String body = writer.output();
             if (size > 0 && !LogCollectConfigUtils.isResponseBodyTooLarge(size)) {
+                String body = writer.output();
                 logInfo.setResponseBody(body);
             }
         } else {
@@ -261,8 +261,8 @@ public void logError(final Throwable throwable) {
         }
 
         int size = bytes.length;
-        String body = new String(bytes, StandardCharsets.UTF_8);
         if (size > 0 && !LogCollectConfigUtils.isResponseBodyTooLarge(size)) {
+            String body = new String(bytes, StandardCharsets.UTF_8);
             logInfo.setResponseBody(body);
         }
         // collect log