[Feature] Support for tracking in spring gateway versions 4.1.2 and above #747
Conversation
|
|
||
| @Override | ||
| public boolean isOverrideArgs() { | ||
| return true; |
There was a problem hiding this comment.
Why true? I can't see you override the args in the interceptor.
There was a problem hiding this comment.
Why true? I can't see you override the args in the interceptor.
You are right, it should not be true
It seems we face Windows limitations. Usually, we need to adjust the configuration of Windows. |
…ace_id' into feature_support_gateway_4.1.2_trace_id
Will it affect the submission of this file? |
|
The new added file seems to exceed length limitation. |
How should we handle this issue? Should we modify it to a shorter file name? But I don't have a Windows environment to verify how suitable it is. Do you have any good suggestions |
@kezhenxu94 Do you have any recommendation to fix this in CI? |
…ace_id' into feature_support_gateway_4.1.2_trace_id
…ace_id' into feature_support_gateway_4.1.2_trace_id
@yqw570994511 Can you please separate the command I added for windows only? Only add that command for windows platform. I'm not with my laptop now |
I'd love to help, but I'm not familiar with this and don't know how to operate it |
Never mind. I've fixed it |
|
@kezhenxu94 notice this
|
Support for tracking in spring gateway versions 4.1.2 and above
see:apache/skywalking#12925