You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminate repeated code with HttpServletRequestWrapper in mvc-annotation-commons.
There is a lot of duplicate code in the AbstractMethodInterceptor of mvc-annotation-commons, mainly due to the change in the package name of Servlet after JDK 17. This PR uses an HttpServletRequestWrapper to shield code differences, reduce duplicate code, and facilitate subsequent maintenance.
[ x ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
Error: src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/interceptor/AbstractMethodInterceptor.java:[36,59] (imports) AvoidStarImport: Using the '.' form of import should be avoided - org.apache.skywalking.apm.plugin.spring.mvc.commons..
Error: src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/interceptor/AbstractMethodInterceptor.java:[159,113] (whitespace) WhitespaceAround: '{' is not preceded with whitespace.
Error: src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/interceptor/AbstractMethodInterceptor.java:[166,94] (whitespace) WhitespaceAfter: ',' is not followed by whitespace.
Error: src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/HttpServletRequestWrappers.java:[22,1] (whitespace) EmptyLineSeparator: 'import' has more than 1 empty lines before.
Error: src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/HttpServletRequestWrappers.java:[71,9] (whitespace) EmptyLineSeparator: '}' has more than 1 empty lines after.
Error: src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/HttpServletRequestWrappers.java:[111,9] (whitespace) EmptyLineSeparator: '}' has more than 1 empty lines after.
Error: src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/HttpServletRequestWrapper.java:[18,1] (whitespace) EmptyLineSeparator: 'package' should be separated from previous line.
Error: src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/HttpServletRequestWrapper.java:[21,1] (whitespace) EmptyLineSeparator: 'import' has more than 1 empty lines before.
Error: Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.2.1:check (validate) on project apm-springmvc-annotation-commons: You have 8 Checkstyle violations. -> [Help 1]
You are not using the upstream code style. Please import them and fix the issue.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminate repeated code with HttpServletRequestWrapper in mvc-annotation-commons.
There is a lot of duplicate code in the AbstractMethodInterceptor of mvc-annotation-commons, mainly due to the change in the package name of Servlet after JDK 17. This PR uses an HttpServletRequestWrapper to shield code differences, reduce duplicate code, and facilitate subsequent maintenance.
CHANGESlog.