ci: add linter for ansible playbook and disable dependentbot #31
Conversation
|
CI somehow fails. Please check. |
| @@ -15,19 +15,19 @@ | |||
|
|
|||
| --- | |||
| - name: Install Java 11 on RHEL-based systems | |||
| package: | |||
| ansible.builtin.package: | |||
There was a problem hiding this comment.
Let's not use the ansible.builtin.. I know this is being explicit instead of implicit. However, this is inconsistent with all our other playbooks. Also, this has no impact on the functioning of our playbooks. Let me know of you think otherwise.
There was a problem hiding this comment.
Let's not use the
ansible.builtin.. I know this is being explicit instead of implicit. However, this is inconsistent with all our other playbooks. Also, this has no impact on the functioning of our playbooks. Let me know of you think otherwise.
Thanks for the comment, the purpose of this pull request is to unify all the module names by using full-qualified names, and should be fixed in all playbooks in this repo, so if there is anything missing then I shall fix them all in this PR.
The main purpose is to add a linter to remind simple errors that might be introduced, and the default rules of the linter complains the builtin modules should be explicitly prefixed with ansible.builtin., do you prefer we skip this rule? I can add the rule to the skip list so we don't report this kind of errors in the linter
There was a problem hiding this comment.
From what I understand, if the linter suggests we must be explicit then let's be explicit. Also, I think the linter would work on PRs as we make changes to files. So let us not touch all the files and make changes rather with time as we make changes to playbooks, the linter will pop up and state modules explicitly. What do you think?
There was a problem hiding this comment.
OK, let me close the PR for now
No description provided.