Implement self-monitoring for BanyanDB via OAP Server and UI #13527
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements self-monitoring capabilities for BanyanDB through integration with the OAP Server and UI dashboard. The implementation enables monitoring of BanyanDB performance metrics including CPU usage, memory utilization, disk usage, network activity, and database-specific operations.
Key changes:
- Adds OTEL metric collection rules for BanyanDB monitoring
- Creates a comprehensive UI dashboard template with 24 monitoring widgets
- Implements end-to-end testing infrastructure for BanyanDB monitoring
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/Layer.java | Adds BANYANDB layer enum for service categorization |
| oap-server/server-starter/src/main/resources/otel-rules/banyandb.yaml | Defines metric transformation rules for BanyanDB Prometheus metrics |
| oap-server/server-starter/src/main/resources/application.yml | Enables banyandb OTEL metrics processing |
| oap-server/server-starter/src/main/resources/ui-initialized-templates/banyandb/banyandb_service.json | Creates comprehensive monitoring dashboard with performance widgets |
| test/e2e-v2/cases/banyandb/* | Adds complete E2E testing infrastructure for BanyanDB monitoring |
| docs/en/changes/changes.md | Documents the new feature in changelog |
Comments suppressed due to low confidence (1)
oap-server/server-starter/src/main/resources/otel-rules/banyandb.yaml:1
- There's a spelling error in the title. 'opeartion' should be 'operation'.
# Licensed to the Apache Software Foundation (ASF) under one or more
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...er/server-starter/src/main/resources/ui-initialized-templates/banyandb/banyandb_service.json
Outdated
Show resolved
Hide resolved
|
You should follow code style provided in the root folder, and format the codes. |
|
@firebor, please add your UI screenshot. |
docs/en/changes/changes.md
Outdated
|
|
||
| #### Project | ||
|
|
||
| * Implement self-monitoring for BanyanDB via OAP Server and UI |
There was a problem hiding this comment.
This is not a project-level change. Project-level change is a highlight feature change. This feature is just an extension.
Please add the changes to OAP Server and UI sections separately.
There was a problem hiding this comment.
OAP Server
- Implement self-monitoring for BanyanDB via OAP Server.
UI
- Implement self-monitoring for BanyanDB via UI.
No UI menu YAML file changes have been added. How do you test this new page locally? |
|
|
How do you open this menu without menu file change? From dashboard pages? |
…mplates/banyandb/banyandb_service.json fix error name Co-authored-by: Copilot <[email protected]>
Manually import JSON files（banyandb_service.json） |
|
This config should be initialized automatically and show up on the menu bar after metrics of BanyanDB collected. |
|
And fix CI. |
| documentLink: https://skywalking.apache.org/docs/main/next/en/setup/backend/dashboards-so11y-go-agent/ | ||
| i18nKey: self_observability_go_agent | ||
| i18nKey: self_observability_go_agent | ||
| - title: BanyanDB Server |
There was a problem hiding this comment.
Please move this before Java agent.
There was a problem hiding this comment.
And as i18nKey added, we need to update UI accordingly.
If this is non-trivial feature, paste the links/URLs to the design doc.
Update the documentation to include this new feature.
Tests(including UT, IT, E2E) are added to verify the new feature.
If it's UI related, attach the screenshots below.
If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
Update the
CHANGESlog.