-
Notifications
You must be signed in to change notification settings - Fork 767
Update dependency com.lmax:disruptor to v4 #3127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
solrbot
wants to merge
1
commit into
apache:main
Choose a base branch
from
solrbot:renovate/major-lmax.disruptor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malliaridis
reviewed
Jan 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From previous review, this upgrade requires log4j to be updated first.
Therefore, blocked by #2895.
e43d298
to
99266d5
Compare
99266d5
to
8f96ef6
Compare
8f96ef6
to
9ab8154
Compare
9ab8154
to
0dd8e55
Compare
0dd8e55
to
f73bd21
Compare
cb689ba
to
7326370
Compare
7326370
to
c47fb74
Compare
533f9cd
to
a36bf81
Compare
Log4j Core has introduced support for Disruptor 4.x in version 2.23.0 (see the Log4j 2.23.0 release notes). To make this PR build successfully, you’ll need to merge #3079 first. |
b4424f5
to
8395235
Compare
ed1fab2
to
096d7ed
Compare
096d7ed
to
0620136
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
3.4.4
->4.0.0
Release Notes
LMAX-Exchange/disruptor (com.lmax:disruptor)
v4.0.0
Compare Source
WorkerPool
andWorkProcessor
have been removed, no moreDisruptor::handleEventsWithWorkerPool
Disruptor
constructors usingExecutor
have been removed. UseThreadFactory
instead.EventHandler
:BatchStartAware
LifecycleAware
SequenceReportingEventHandler
FatalExceptionHandler
andIgnoreExceptionHandler
now use the JDK 9 Platform Logging API, i.e.System.Logger
BatchEventProcessor
BatchEventProcessor
EventHandler::onBatchStart
now gets both thebatchSize
as well asqueueDepth
(previously it hadbatchSize
which reported queue depth)EventPoller
Util::log2
throws if passed a non-positive argumentThreadHints.onSpinWait()
Disruptor.handleExceptionsWith()
- this had been javadoc deprecated since 2015 but not in the codeRingbuffer.resetTo()
ConsumerRepository.getLastSequenceInChain()
Configuration
📅 Schedule: Branch creation - Every minute ( * * * * * ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot