-
Notifications
You must be signed in to change notification settings - Fork 769
Upgrade Log4j to 2.25.2
#3603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Upgrade Log4j to 2.25.2
#3603
Conversation
Remove explicit dependencies on `osgi.annotation` and `biz.aQute.bnd.annotation`. Since Log4j 2.25.0, all artifacts publish Gradle Module Metadata that brings in these annotation libs as transitive compile-only dependencies, avoiding `-Xlint:classfile` warnings without needing to declare them directly.
Remove `spotbugs-annotations` pulled in via Apache POI as a transitive **compile-only** dependency. It is not required for the build but triggers license check failures because SpotBugs (including its annotations) is licensed under LGPL-2.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick view, looks great, thanks for diving in. Note that when the PR is not authored by solrbot
, it will not be auto included in CHANGES.txt "Dependency upgrades" section, so you'll have to add a line there yourself.
I switched this PR to draft, since we have scheduled a release |
We released version |
This PR updates all Log4j artifacts to version 2.25.1 and includes a few related cleanups:
Supersedes Update apache.log4j to v2.25.2 #3079.
Removes explicit dependencies on
osgi.annotation
andbiz.aQute.bnd.annotation
.-Xlint:classfile
compiler warnings without extra dependencies.Excludes
spotbugs-annotations
(brought in transitively via Apache POI).Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.