[SPARK-48719][SQL] Fix the calculation bug of RegrSlope & RegrIntercept when the first parameter is null
#47105
+19
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wayneguow
commented
Jun 26, 2024
| @@ -1,7 +1,7 @@ | |||
| -- Automatically generated by SQLQueryTestSuite | |||
| -- !query | |||
| CREATE OR REPLACE TEMPORARY VIEW testRegression AS SELECT * FROM VALUES | |||
| (1, 10, null), (2, 10, 11), (2, 20, 22), (2, 25, null), (2, 30, 35) | |||
| (1, 10, null), (2, 10, 11), (2, 20, 22), (2, 25, null), (2, 30, 35), (2, null, 40) | |||
There was a problem hiding this comment.
A tuple is added with the value of y is null, it should be filtered out during calculation, so the output related to RegrSlope & RegrIntercept in the output remains unchanged.
wayneguow
changed the title
RegrSlope&RegrIntercept` when the first parameter is nullRegrSlope & RegrIntercept when the first parameter is null
|
cc @beliefer |
mihailom-db
approved these changes
Jun 27, 2024
|
Gentle ping @HyukjinKwon, when you have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix the calculation bug of
RegrSlope&RegrIntercept` when the first parameter is null. Regardless of whether the first parameter(y) or the second parameter(x) is null, this tuple should be filtered out.Why are the changes needed?
Fix bug.
Does this PR introduce any user-facing change?
Yes, the calculation changes when the first value of a tuple is null, but the value is truly correct.
How was this patch tested?
Pass GA and test with
build/sbt "~sql/testOnly org.apache.spark.sql.SQLQueryTestSuite -- -z linear-regression.sql"Was this patch authored or co-authored using generative AI tooling?
No.