[SPARK-48715][SQL] Integrate UTF8String validation into collation-aware string function implementations #47131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaravel
reviewed
Jul 2, 2024
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
Show resolved
Hide resolved
uros-db
changed the title
mkaravel
reviewed
Jul 3, 2024
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
Outdated
Show resolved
Hide resolved
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java
Show resolved
Hide resolved
cloud-fan
approved these changes
Jul 4, 2024
cloud-fan
changed the title
|
thanks, merging to master! |
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Jul 10, 2024
…re string function implementations ### What changes were proposed in this pull request? Use our own invalid UTF-8 byte sequence replacement logic in UTF8String, before all `.toString()` method calls. ### Why are the changes needed? Avoid relying on Java to perform invalid UTF-8 byte sequence replacement, and ensure consistent results. ### Does this PR introduce _any_ user-facing change? Yes, collation aware string function implementations will now rely on our own invalid UTF-8 string replacement implementation, instead of Java's. ### How was this patch tested? Existing tests, with some changes in `UTF8StringSuite` and `CollationSupportSuite`. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47131 from uros-db/make-valid. Authored-by: Uros Bojanic <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use our own invalid UTF-8 byte sequence replacement logic in UTF8String, before all
.toString()method calls.Why are the changes needed?
Avoid relying on Java to perform invalid UTF-8 byte sequence replacement, and ensure consistent results.
Does this PR introduce any user-facing change?
Yes, collation aware string function implementations will now rely on our own invalid UTF-8 string replacement implementation, instead of Java's.
How was this patch tested?
Existing tests, with some changes in
UTF8StringSuiteandCollationSupportSuite.Was this patch authored or co-authored using generative AI tooling?
No.