[SPARK-48586][SS][FOLLOWUP] RocksDB and RocksDBFileManager code style changes #47136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeartSaVioR
changed the title
|
Merged to master. |
|
It has a conflict in 3.5 and 3.4. Mind creating a backport PR @riyaverm-db ? |
|
Backport PR for 3.5 contains this followup fix, so we just need to merge that PR to be done. |
asl3
pushed a commit
to asl3/spark
that referenced
this pull request
Jul 1, 2024
… changes ### What changes were proposed in this pull request? This is a follow up PR to apache#46942 addressing the style changes that were requested. ### Why are the changes needed? Style changes added. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Not applicable. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47136 from riyaverm-db/rocks-db-style. Authored-by: Riya Verma <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow up PR to #46942 addressing the style changes that were requested.
Why are the changes needed?
Style changes added.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Not applicable.
Was this patch authored or co-authored using generative AI tooling?
No